fix: renderTags returning invalid htmls - Githubissues

solidjs / solid-meta

Write meta tags to the document head

127 stars 16 forks source link

fix: renderTags returning invalid htmls #1

Closed phiberber closed 2 years ago

phiberber commented 2 years ago

Not joining attributes, returning into an Array.toString() call which basically returns () => join(",")
Not checking to see if elements have children, resulting in empty elements.

Before: <title data-sm=""> Sample Title </title><meta data-sm="" name="keywords", content="sample, title"></meta>

After <title data-sm=""> Sample Title </title><meta data-sm="" name="keywords" content="sample, title" />

ryansolid commented 2 years ago

Thanks