search

solidjs / solid-meta

Write meta tags to the document head
127 stars 16 forks source link

Remove data-sm attribute #2

Closed poudels14 closed 2 years ago

poudels14 commented 2 years ago

including style using <link ... /> doesn't work if there's "data-sm" attribute in

Not sure if there's something else going on but removing this tag seems to work.

ryansolid commented 2 years ago

This is there specifically so that it is removed and the client can re-render it. Otherwise you can end up with duplicate tags.

Basically we have no way to hydrate this portion of the document so we clear it and re-render as the client initializes. Maybe we can add an option not to mark this for removal, which I'm gathering is your intention. I'm gathering you are only rendering the tags on the server? But that can't be the default way as it isn't the common case.

poudels14 commented 2 years ago

That makes sense. Yes, I am only rendering script/css tags in the server. I will use local patch for now and will revisit this PR later.