search

solidjs / solid-meta

Write meta tags to the document head
127 stars 16 forks source link

Using multiple values from routeData object in Title appears to insert extra commas #37

Closed rpivo closed 3 months ago

rpivo commented 9 months ago

Reproduced issue here: https://stackblitz.com/edit/solidjs-templates-pblvuq?file=src%2Froutes%2Ftest%2F%5Bid%5D.tsx

Start with npm run dev, then navigate to route /test/1.

The title should read abel bernice charlie, but instead it reads abel, ,bernice, ,charlie.

I am not sure that this has anything to do with using routeData at all -- this is just how I am able to reproduce the issue.

iacore commented 8 months ago

the children are treated as a list.

workaround: concatenate the strings yourself

JakkuSakura commented 3 months ago

Isn't the list be concatenated with no spacing, like any other children in JSX components

iacore commented 3 months ago

Isn't the list be concatenated with no spacing, like any other children in JSX components

[1, 2].toString()