This PR addresses an issue in renderTags where commas are inserted out of nowhere. This happens because the code assumes that there will only ever be one child node. When it receives multiple text nodes there is an implicit array to string conversion which then inserts the comma.
const company = "My cool company"
<Title>blabla - {company}</Title>
Old output:
<title>blabla - ,My cool company</title>
With this PR:
<title>blabla - My cool company</title>
Not sure if just checking via Array.isArray is the idiomatic way to check for singular vs multiple children in solid.
This PR addresses an issue in
renderTags
where commas are inserted out of nowhere. This happens because the code assumes that there will only ever be one child node. When it receives multiple text nodes there is an implicit array to string conversion which then inserts the comma.Old output:
With this PR:
Not sure if just checking via
Array.isArray
is the idiomatic way to check for singular vs multiple children in solid.