search

solidjs / solid-playground

Quickly discover what the solid compiler will generate from your JSX template
https://playground.solidjs.com
MIT License
201 stars 62 forks source link

Old "hashed" (aka `lz-string`-ed) Playground links are broken #147

Open AlexErrant opened 1 year ago

AlexErrant commented 1 year ago

I found a playground link in this issue:

https://playground.solidjs.com/?version=1.3.5#NobwRAdghgtgpmAXGGUCWEwBowBcCeADgsrgM4Ae2YZA9gK4BOAxiWGjIbY7gAQi9GcCABM4jXgF9eAM0a0YvADo1aAGzQiAtACsyAegDucAEYqA3EogcuPfr2ZCouOAGU0Ac2hqsvWhABhNTgoCHpCKVl5RRU6DW09CysrGXoIZlw0f14AhggXRgAKAEp+K14HfzI+YGY83F8yOFxctNwAXV4AXgcnF3cvKDVCgAZiywgK8t5gvk1u3ibcAEl88QA3IcKS7oA+RebW-MK6tp2Aal4ARmLfK5GH8en-IJCwwm3Srv3mYKhGVYFTbDTTFJ4QaZCXBMSaFaYVAA8JnouFw2QIxC6KmRqP8Kj8gQ0zAA1l0QLU9pUIHE4AA6NS0DwnW6VM7FdqSXbwipUmn0xk7ZhMIT5VmiwogU7HYqSYrchH6HFoiBcya8cGSZIQEViIo7b68BFHAq8fS7XwiWhC+D5WkeZoAUWCNtwACF8MsRHCwFBCIQVGCJmBJO0gA

Opening the above link in Chrome incognito, Chrome Guest mode, and Chrome Canary Guest mode all yield the default counter; not whatever the author customized.

However, when I clone and run the repo locally, the following link works (in both dev and preview):

http://localhost:4173/?version=1.3.5#NobwRAdghgtgpmAXGGUCWEwBowBcCeADgsrgM4Ae2YZA9gK4BOAxiWGjIbY7gAQi9GcCABM4jXgF9eAM0a0YvADo1aAGzQiAtACsyAegDucAEYqA3EogcuPfr2ZCouOAGU0Ac2hqsvWhABhNTgoCHpCKVl5RRU6DW09CysrGXoIZlw0f14AhggXRgAKAEp+K14HfzI+YGY83F8yOFxctNwAXV4AXgcnF3cvKDVCgAZiywgK8t5gvk1u3ibcAEl88QA3IcKS7oA+RebW-MK6tp2Aal4ARmLfK5GH8en-IJCwwm3Srv3mYKhGVYFTbDTTFJ4QaZCXBMSaFaYVAA8JnouFw2QIxC6KmRqP8Kj8gQ0zAA1l0QLU9pUIHE4AA6NS0DwnW6VM7FdqSXbwipUmn0xk7ZhMIT5VmiwogU7HYqSYrchH6HFoiBcya8cGSZIQEViIo7b68BFHAq8fS7XwiWhC+D5WkeZoAUWCNtwACF8MsRHCwFBCIQVGCJmBJO0gA

(In particular, the onClick looks like onClick={[c => console.log(c), count()]})

I think there's an old deploy on https://playground.solidjs.com that's broken...? I don't see any Github Actions, so I don't know anything :D

milomg commented 6 months ago

We currently deploy a series of patches on top of main (https://github.com/solidjs/solid-playground/tree/legacy), looks like one of them must've broken this feature...