search

solidjs / solid-playground

Quickly discover what the solid compiler will generate from your JSX template
https://playground.solidjs.com
MIT License
201 stars 62 forks source link

Update all dependencies to latest #165

Closed birkskyum closed 7 months ago

birkskyum commented 7 months ago

I use the playground for debugging / learning about the SolidJS compile output in different environments, but it requires the deps to be on the latest versions to stay relevant for that, since the dom-expressions library evolve and change the output etc.

This PR update all dependencies to their latest.

I paid a lot of attention to avoid any visual changes / regressions, and all interesting changes are explained in the comments below.

This is best to run on at least Node 18, preferably 20, due to Vite 5 etc.

milomg commented 7 months ago

This looks awesome! Can you run a quick pnpm run format? (I think I should be able to merge and rebase this over the weekend)

birkskyum commented 7 months ago

Excellent! It's formatted now

milomg commented 7 months ago

Another interesting bug that I just noticed: resizing the vertical split pane seems to be broken... I wonder what is causing this

birkskyum commented 7 months ago

@modderme123 , I'll investigate a bit. I don't experience the resizing issue - What is your os / node / browser version?

milomg commented 7 months ago

Mac, latest chrome. Dragging vigorously today made it go away. Must've been a bug in chrome

milomg commented 7 months ago

Thank you!