solidjs / solid-playground

Quickly discover what the solid compiler will generate from your JSX template
https://playground.solidjs.com
MIT License
193 stars 62 forks source link

Incorrect file extensions published to npm #178

Open NullVoxPopuli opened 1 month ago

NullVoxPopuli commented 1 month ago

Just saw image

(I'm poking around!) :D

And there is non-JS syntax in here.

I believe that should be compiled away yeah? (or if the consuming project is responsible for further-compiling the library, the file extension should be jsx, yeah?)

thanks! (lemme know if I misunderstand something! <3)

NullVoxPopuli commented 1 month ago

omg, I missed that this is all in a string. everything is fine.

MORE COFFEE

NullVoxPopuli commented 1 month ago

actually no, I think I still have a question about use of jsx in a published package:

image

This file doesn't need to be jsx tho :thinking: image

milomg commented 3 weeks ago

I believe we mark the root as jsx so that vite compiles the package with babel (otherwise we've had problems with it skipping the SolidJS transform for this package)