search

solidjs / solid-playground

Quickly discover what the solid compiler will generate from your JSX template
https://playground.solidjs.com
MIT License
193 stars 62 forks source link

Should there be a central store for playground? #58

Closed trivikr closed 2 years ago

trivikr commented 3 years ago

Is your feature request related to a problem? Please describe.

While working on the dark mode in the following PRs, I noticed that lot of props are passed around.

Should there be a central store for these signals, so that they're not required to be passed between components? PR for an attempt to create a store for dark signal in https://github.com/solidjs/solid-playground/pull/57

Describe the solution you'd like

A better project structure where all TypeScript code is under src folder, and there's a central store from which values can be read.

Describe alternatives you've considered

Keep passing values of signals between components as props.

amoutonbrady commented 3 years ago

I'll let @modderme123 handle that one, he's been doing a lot of work around the architecture of the playground since we moved to a published component.

milomg commented 2 years ago

Closing as I introduce a central store in https://github.com/solidjs/solid-playground/pull/107