search

solidjs / solid-refresh

MIT License
85 stars 18 forks source link

Default @refresh pragma #16

Open edemaine opened 2 years ago

edemaine commented 2 years ago

Could we add an option (here and the solid-vite-plugin that includes this) to specify the default @refresh pragma, for files that don't override @refresh? And I guess we'd need to give a name to the current default behavior, so you could opt back into it. Maybe /* @refresh replace */?

Motivation: The more I experience HMR (e.g. changing solid-playground), the more I find it buggy for the types of changes I make; for certain types of testing/debugging, I really want the full page reload every time. I basically don't trust the HMR results and manually reload every time. So I'd like to be able to specify a default of /* @refresh reload */.

lxsmnsyc commented 2 years ago

If we desire a full page reload by default, perhaps not using solid-refresh shouldn't be a problem? There isn't much difference to it.

edemaine commented 2 years ago

I guess I imagined a code base that had some well-behaved files, which could be marked, while the rest are assumed side-effecty. But I'd probably be fine with turning solid-refresh on/off as needed (when editing styles/text vs doing complex code edits). Is there am easy way to do that with solid-vite-plugin though?

lxsmnsyc commented 2 years ago

yes, with hot: false