search

solidjs / solid-refresh

MIT License
85 stars 18 forks source link

Esbuild support? #32

Closed woodcox closed 8 months ago

woodcox commented 1 year ago

Is there esbuild support for solid-refresh? I use the esbuild-plugin-solid rather than vite.

lxsmnsyc commented 1 year ago

esbuild doesn't have HMR so I don't think using solid-refresh on esbuild will do anything

woodcox commented 1 year ago

Would it work with a similar approach to esbuild-hmr?

lxsmnsyc commented 1 year ago

well for that kind of setup you'd need to write an esbuild plugin that uses transform + solid-refresh w/ esm mode setup

woodcox commented 1 year ago

Yeah building an esbuild-solid-hmr plugin is probably a bit beyond my JS skill level at the moment. But maybe longer term it’s something I could figure out……

lxsmnsyc commented 8 months ago

Since ESBuild doesn't have an HMR API this issue is a wontfix