search

solidjs / solid-router

A universal router for Solid inspired by Ember and React Router
MIT License
1.14k stars 147 forks source link

[Documentation] README example incorrect? #315

Closed aalmazan closed 10 months ago

aalmazan commented 10 months ago

Describe the bug

https://github.com/solidjs/solid-router/blob/898174ee1b86e005d1e006ebbb4cf4953e614dc2/README.md?plain=1#L418-L438

Confused with the code snippet above. Is there another function deleteUser (or deleteTodo) that we need to know of or are all the function references supposed to point to a single function?

Your Example Website or App

N/A

Steps to Reproduce the Bug or Issue

  1. Visit https://github.com/solidjs/solid-router/blob/898174ee1b86e005d1e006ebbb4cf4953e614dc2/README.md?plain=1#L418-L438 to check affected lines

Expected behavior

Maybe more clarity on what actions is doing

Screenshots or Videos

No response

Platform

Any

Additional context

No response

ryansolid commented 10 months ago

Thanks.. my bad from missing a reference.