search

solidjs / solid-router

A universal router for Solid inspired by Ember and React Router
MIT License
1.14k stars 147 forks source link

Add function for cache invalidation #327

Closed pedro00dk closed 9 months ago

pedro00dk commented 10 months ago

Hi, I started migrating an app from solidjs router 0.9.x and 0.10.x. The new caching and preload features are nice, but I'm having some trouble with testing. In my test setup I intercept API requests and inject different stubs for different tests. Since the tests run fast, the new solid router cache function does not invalidate the cache from one test to the next, causing some tests to get API responses made for previous tests when making the same requests.

I looked at the source code of cache and there seems to be no way to invalidate the entire cache. I saw that there is a cache.set function there but it seems it can't be used for invalidating individual caches. I really don't want to change components' code to fetch without caching for tests, so it would be interesting to have some sort of cache.clear to invalidate the entire cache for testing purposes.

I just created this as a pull request because it is not really an issue and the change proposal is very small, but there might be better ways to do this invalidation.

ryansolid commented 9 months ago

Hmm.. this is fine for your case. Trying to think of the downsides. Any live resource won't retrigger, but I think that's what we want. We just want it clear. The next time we hit it, it's new again.