solidjs / solid-router

A universal router for Solid inspired by Ember and React Router
MIT License
1.13k stars 143 forks source link

useNavigate() replace the browser history #332

Closed T3ch0o closed 2 months ago

T3ch0o commented 8 months ago

Describe the bug

Even inside navigation('url', { replace: false }) is by default the history is replaced and when clicking back the url doesn't change and after that goes to a random places. Migrated from ver. 9 to ver. 10 i didn't touch the logic at all. It worked as expected at ver. 9

Your Example Website or App

localhost

Steps to Reproduce the Bug or Issue

  1. import useNavigate
  2. navigate to any different route besides the current

Expected behavior

Expecting to go back on the previous route that i was in!

Screenshots or Videos

No response

Platform

Additional context

No response

femincan commented 8 months ago

I've tried to reproduce your issue, but couldn't succeed. Everything worked as expected for me.

Could something else be the cause of the problem? Could you please provide more information?

pixelprogrammer commented 5 months ago

Should this issue be closed since there hasn't been more information provided?

I haven't had this issue from version 0.9 -> 0.13. If there is no way to reproduce this from basic examples then I don't think its an issue in its current state.

I can confirm it works in version 0.13.0 at least.

ryansolid commented 2 months ago

@pixelprogrammer thanks for testing. Yes I will close. Feel free to submit again with a reproduction.