Data reconcilation for cached functions works incorrectly under some conditions - Githubissues

solidjs / solid-router

A universal router for Solid inspired by Ember and React Router

MIT License

1.11k stars 138 forks source link

Data reconcilation for cached functions works incorrectly under some conditions #343

Closed elite174 closed 6 months ago

elite174 commented 7 months ago

Describe the bug

On the first cache revalidation, data is reconciled incorrectly, which causes rerenders.

Example: https://playground.solidjs.com/anonymous/b6b25440-9d66-467e-94ee-5148484a5bc2

You'll see in the console that items are rerendered on the first revalidation, however it doesn't happen when you continue revalidate the data.

Your Example Website or App

https://playground.solidjs.com/anonymous/b6b25440-9d66-467e-94ee-5148484a5bc2

Steps to Reproduce the Bug or Issue

Check out the example

Expected behavior

Items should be reconciled correctly without rerenders

Screenshots or Videos

No response

Platform

OS: [e.g. macOS, Windows, Linux]
Browser: [e.g. Chrome, Safari, Firefox]
Version: [e.g. 91.1]

Additional context

No response

ryansolid commented 6 months ago

Thanks.. I missed this. I'm trying to track this one down but its odd.. Somehow on first load we aren't getting the wrapped value. I see it.. empty intent on initial load. Ok I will get this fixed.