search

solidjs / solid-router

A universal router for Solid inspired by Ember and React Router
MIT License
1.14k stars 146 forks source link

don't submit form when submitevent get defaultPrevented #401

Closed SarguelUnda closed 6 months ago

SarguelUnda commented 6 months ago

Fix #400

Objective

The pull request aim to not run action when someone call preventDefault on the submitevent.

Remarks

  1. I didn't run prettier and there is a ts error when I build the project that was already there.
  2. I'm not sure where to abort the handleFormSubmit function I choose to abort as soon as possible but maybe there are better place performance wise
changeset-bot[bot] commented 6 months ago

🦋 Changeset detected

Latest commit: 8a547a8e7971d9e4d79448cd867928ce04d38d88

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------------- | ----- | | @solidjs/router | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ryansolid commented 6 months ago

Thanks