search

solidjs / solid-router

A universal router for Solid inspired by Ember and React Router
MIT License
1.1k stars 137 forks source link

Mark touchstart event listener passive #424

Closed Legend-Master closed 1 month ago

Legend-Master commented 1 month ago

We don't call preventDefault in the handler, so marking it as passive event handler to improve scrolling performance

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: b718e87bfba0e31422d3092e7e100e04560087ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------------- | ----- | | @solidjs/router | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Legend-Master commented 1 month ago

Sorry, touchstart event listeners are passive by default on all modern browsers, please ignore

I probably accidentally clicked Toggle Passive in devtools and it showed me that listener is not passive