Make useCurrentMatches a getter function

solidjs / solid-router

A universal router for Solid inspired by Ember and React Router

MIT License

1.1k stars 137 forks source link

Make useCurrentMatches a getter function #427

Closed Brendonovich closed 1 month ago

Brendonovich commented 1 month ago

useCurrentMatches should return a getter function like useIsRouting, useMatches, etc. Haven't made a changeset yet as I'm not sure if this is a minor or patch change.

Closes #425

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 75472d2ee4456c5c0040f1b3ff53277af1b21a36

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | --------------- | ----- | | @solidjs/router | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ryansolid commented 1 month ago

Yeah this was probably an oversight.. I was seeing a function calling a function.. yeah ok technically it is breaking. So I guess bump a minor.

ryansolid commented 1 month ago

Actually I documented this working the other way so this is a bug..