Fixes #434 - Export type Route as RouteInfo

solidjs / solid-router

A universal router for Solid inspired by Ember and React Router

MIT License

1.1k stars 137 forks source link

Fixes #434 - Export type Route as RouteInfo #435

Closed jpdutoit closed 1 month ago

jpdutoit commented 1 month ago

Fixes #434

Unfortunately in #432, the exported type and value Route did not merge correctly, breaking the library. It is possible to re-export them under the same name, but since the Route type was not part of the public API before renaming it seems cleaner.

I chose RouteInfo as the new exported name for the type.

If you prefer, I could rename type Route globally in the project instead of just the export.

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 8c1dfb0e6fce80f11786c9ec6bbbcdf263849ca8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | --------------- | ----- | | @solidjs/router | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ryansolid commented 1 month ago

I see it isn't the Route Component but the internal Route representation. It's unfortunate that info already is a field, but I'm having a hard time coming up for a name for this one. We already have RouteDefinition for the input, Route for the component. Maybe RouteDescription. I see the problem I will try to work with this. Thanks.