ErrorBoundary fallback renders twice - Githubissues

solidjs / solid-router

A universal router for Solid inspired by Ember and React Router

MIT License

1.1k stars 137 forks source link

ErrorBoundary fallback renders twice #440

Closed andreiborza closed 3 weeks ago

andreiborza commented 1 month ago

Describe the bug

The ErrorBoundary fallback component renders twice when using solid router and navigating to a route that has an ErrorBoundary with an error.

Your Example Website or App

https://codesandbox.io/p/devbox/nameless-forest-45lzdm?file=%2Fsrc%2Findex.tsx%3A11%2C35

Steps to Reproduce the Bug or Issue

Open console
Click on the Go to error link

Expected behavior

Error should only be logged out once but is logged out twice.

Screenshots or Videos

https://github.com/solidjs/solid-router/assets/168741329/d40bd7a8-fed9-4fce-abdd-4a64dc8645ef

Platform

OS: macOS
Browser: Chrome
Version: [e.g. 91.1]

Additional context

Possibly related to: https://github.com/solidjs/solid/issues/1586

ryansolid commented 3 weeks ago

Looks like issue is also closed by https://github.com/solidjs/solid-router/pull/442. I will have a release out shortly.

andreiborza commented 3 weeks ago

Can confirm, it's fixed!