search

solidjs / solid-router

A universal router for Solid inspired by Ember and React Router
MIT License
1.1k stars 137 forks source link

Treat `window.location.hash` as URI encoded #444

Closed Brendonovich closed 1 month ago

Brendonovich commented 1 month ago

window.location.hash is URI encoded, but not HTML element ids, so the element lookup for scrollToHash fails when the has contains characters affected by URI encoding.

Closes #421

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 8fbf74a2c655d824db77f97cca4bb2a9dd478e8a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------------- | ----- | | @solidjs/router | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR