search

solidjs / solid-router

A universal router for Solid inspired by Ember and React Router
MIT License
1.1k stars 137 forks source link

Drive letter is added to relative path on navigation when page is build on windows #448

Closed bartcharbon closed 2 weeks ago

bartcharbon commented 3 weeks ago

Describe the bug

When using "pnpm run build" on a Windows machine the navigation of the web page breaks due to the addition of a Drive letter in the relative path, after the hash.

The same page created on a Linux machine via the same command works fine. (probably related the the Linux paths not containing a drive letter)

Your Example Website or App

https://github.com/molgenis/vip-report-template/issues/319

Steps to Reproduce the Bug or Issue

Navigation to "/test" (via href) results in this url: file:///path/to/test.html#/C:/test

Expected behavior

Navigation to "/test" (via href) results in this url: file:///path/to/test.html#/test

Screenshots or Videos

No response

Platform

Windows Tested on Chrome and Edge, possibly/probably the same for other browsers Version 0.13.5

Additional context

No response

ryansolid commented 3 weeks ago

How are you defining the paths? Is this from SolidStart? Is this during SSR?

bartcharbon commented 2 weeks ago

The problem seems te be on our end, we used lower case <a> for some hrefs, switching to <A> solves the problem.

In fact it was not limited to pages build on windows, not sure why it seemed that way at first