search

solidjs / solid-site

Code that powers the SolidJS.com platform.
https://www.solidjs.com
159 stars 172 forks source link

chore: uncomment markDownRef.scrollTop #466

Closed K-Sato1995 closed 1 year ago

K-Sato1995 commented 1 year ago

Overview

It doesn't scroll up to the top when you click the prev/next chapter on the turtorials page. Changed it to scroll to the top every time a user clicks the prev/next chapter.

Side node:

Not exactly sure why the code was commented. Feel free to close the PR if this is the expected behavior. Also open to discuss better solutions for this.

Current Behavior

https://github.com/solidjs/solid-site/assets/32632542/0b0e7a8d-84da-4874-b560-e34c47a1e87e

Fixed Behavior

https://github.com/solidjs/solid-site/assets/32632542/4dac5bfb-6af8-4f4c-aa65-84d815c3bc97

davedbase commented 1 year ago

That's a very good question why it was commented. It should be there for sure. Thank you!