search

solidjs / solid-site

Code that powers the SolidJS.com platform.
https://www.solidjs.com
159 stars 173 forks source link

Unusable navigation in the SolidJS site #518

Closed vijaybritto closed 4 months ago

vijaybritto commented 6 months ago

Describe the bug

The navigation while viewing in my PC is unusable and scrolls horizontally and vertically at the same time.

Your Example Website or App

https://www.solidjs.com/

Steps to Reproduce the Bug or Issue

  1. Goto https://www.solidjs.com/
  2. Reduce the width of the window to a level where the navigation begins to scroll horizontally
  3. Try to reach links in the navigation

Expected behavior

To be able to scroll horizontally to the end or beginning of the navigation bar

Screenshots or Videos

https://github.com/solidjs/solid/assets/3725668/e1cb4056-4110-469b-849d-d8eeeedd10e4

In the video above I'm trying to reach the last item in the navigation but its scrolling vertically as well. I'm using the mouse wheel

Platform

Additional context

The innerWidth of my window was 1180

titoBouzout commented 4 months ago

Can you check if you are able to reproduce with browser extensions disable?

vijaybritto commented 4 months ago

@titoBouzout I see the same in incognito window as well.

titoBouzout commented 4 months ago

Yes, but did you make sure extensions were disable? because on incognito extensions could be running

birkskyum commented 4 months ago

I can confirm this is an issue with touchpad as well. It needs some preventDefault() on that vertical scroll etc. https://stackoverflow.com/questions/55152799/prevent-window-vertical-scroll-until-divs-horizontal-scroll-reaches-its-end

davedbase commented 4 months ago

Awesome, @vijaybritto and team. Thank you very much for this report. A fix was sent up by @AlidotSal. If you continue seeing an issue let us know on this thread. :)