Fix meta pwa - Githubissues

Brian-Pob commented 5 months ago

Multiple improvements

clean up meta tags in index.html
- removing repeated tags
- adding correct tag attributes
- property= instead of name= for some tags as per OG protocol
implement PWA functionality
- I noticed there was an attempt to include PWA functionality before.
- uses vite-plugin-pwa as it was already part of the dependencies
added images for PWA functionality
- used the existing icons located in public/img/icons
- does not explicitly set PWA options for Android or iOS yet
- screenshot images were taken using Arc browser's screenshot tool
- I can use different images if requested

Brian-Pob commented 5 months ago

Tried deploying my fork onto CF pages and Vercel and couldn't get either to work. :( It does work when I run pnpm dev but running build reveals some errors that I don't know how to fix.

This is the error that pops up whenever build is executed

Cannot use 'in' operator to search for 'children' in undefined
file: .../solid-site-fix-meta/src/pages/Articles/state-of-solid-december-2021.mdx

Edit: Fixed this in 86b3d51

Brian-Pob commented 5 months ago

CFP Preview link https://4748970c.solid-site-fix-meta.pages.dev/

solidjs / solid-site

Fix meta pwa #534