search

solidjs / solid-start

SolidStart, the Solid app framework
https://start.solidjs.com
MIT License
5.19k stars 375 forks source link

[Bug?]: Build check for errors #1019

Closed MariuzM closed 10 months ago

MariuzM commented 1 year ago

Duplicates

Latest version

Current behavior 😯

When doing pnpm build and if there is errors in the project it does not show those in console and continues to build

Expected behavior 🤔

When doing build project should check for any errors and abord build process that also explains where the errors are coming from.

MariuzM commented 1 year ago

One of the solutions is to use vite-plugin-checker this works in dev and build modes.

I did pick up on this error 

 ERROR(TypeScript)  Cannot find module 'server/server-functions/types' or its corresponding type declarations.
 FILE  /Volumes/Media/Dev_Projects/Projects/project-solid/node_modules/.pnpm/solid-start@0.3.3_@solidjs+meta@0.28.6_@solidjs+router@0.8.3_solid-js@1.7.11_solid-start-node@0.3.3_vite@4.4.9/node_modules/solid-start/data/createRouteAction.tsx:6:32

    4 |
    5 | import { Navigator } from "@solidjs/router";
  > 6 | import { ServerFunction } from "server/server-functions/types";
      |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    7 | import type { ParentComponent } from "solid-js";
    8 | import { isRedirectResponse, XSolidStartOrigin } from "../server/responses";
    9 | import { useRequest } from "../server/ServerContext";
ryansolid commented 10 months ago

In setting up for SolidStart's next Beta Phase built on Nitro and Vinxi we are closing all PRs/Issues that will not be merged due to the system changing. If you feel your issue was closed by mistake. Feel free to re-open it after updating/testing against 0.4.x release. Thank you for your patience.

See https://github.com/solidjs/solid-start/pull/1139 for more details.