solidjs / solid-start

SolidStart, the Solid app framework
https://start.solidjs.com
MIT License
5.08k stars 377 forks source link

Update tsconfig type to "vinxi/types/client" #1455

Closed HansT01 closed 5 months ago

HansT01 commented 5 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

Typescript issue, so no tests have been made.

PR Type

What kind of change does this PR introduce?

AFAIK this should only affect new projects.

What is the current and new behavior?

See issue: #1454

changeset-bot[bot] commented 5 months ago

🦋 Changeset detected

Latest commit: 571564cb7389e4d535549c8daa457337d00eaa23

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

HansT01 commented 5 months ago

Related commit: https://github.com/solidjs/solid-start/commit/090df26bed0f91cd17fe1c206dd5469aeb315a11

ryansolid commented 5 months ago

Oh is that where they ended up. Ok awesome.