[Bug?]: Extend Solid config causes TS Errors

ryoid commented 2 months ago

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯

Extending solid config has required fields that should be optional.

// app.config.ts
export default defineConfig({
  solid: {
    // Uncomment to supress errors
    // dev: true,
    // ssr: false,
    // hot: true,
    // solid: {
    //   omitNestedClosingTags: false,
    // },
    babel: {
      env: {
        development: {
          // https://github.com/nksaraf/vinxi/issues/204
          compact: true,
        },
      },
    },
  },
});

Expected behavior 🤔

Should not error since these fields have default values. Looking at vite-plugin-solid it seems like these are optional there.

Steps to reproduce 🕹

https://stackblitz.com/edit/github-e58cde-3el8ng?file=package.json

Steps:

Extend the Solid config in app.config.ts with some babel settings
Observe typescript errors

Context 🔦

Encountered when trying to use config from https://github.com/nksaraf/vinxi/issues/204#issuecomment-2053760779

Your environment 🌎

No response

ryansolid commented 1 month ago

Yeah we fixed this in 2.10.x of Vite Plugin Solid but Start hasn't been updated to it. Thanks for pointing this out.