solidjs / solid-start

SolidStart, the Solid app framework
https://start.solidjs.com
MIT License
4.93k stars 371 forks source link

improved theme selector focused item contrast in light theme #1508

Closed puntogris closed 1 month ago

puntogris commented 1 month ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

When using light theme the themes selector item focused text color is difficult to see(dark text on dark background).

before

What is the new behavior?

Changed the color to light text on dark background on light theme to provide more contrast when focused.

after

Other information

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 96310589d58897da0cf21578832c1e42e1e8273f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ryansolid commented 1 month ago

Thanks