solidjs / solid-start

SolidStart, the Solid app framework
https://start.solidjs.com
MIT License
4.93k stars 371 forks source link

[Bug?]: `Button type attribute has not been set.` in templates #1517

Closed hamirmahal closed 1 month ago

hamirmahal commented 1 month ago

Duplicates

Latest version

Current behavior 😯

Default templates don't specify the type of a button, which is problematic because the default type is submit, not "button", which users may not expect.

Expected behavior 🤔

Templates should specify type="button".

Steps to reproduce 🕹

Steps:

  1. npm init solid@latest
  2. Select with-vitest as a template or any other option that uses a button without specifying its type attribute.

Context 🔦

Ideally, new projects should be free of any errors and linting issues. It's one less thing to do for people who are trying to create a Solid project.

Your environment 🌎

No response