solidjs / solid-start

SolidStart, the Solid app framework
https://start.solidjs.com
MIT License
4.93k stars 371 forks source link

fix: ambiguous attribute for `button` #1518

Closed hamirmahal closed 1 month ago

hamirmahal commented 1 month ago

fixes #1517.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

New projects created from specific templates use a button without specifying the type attribute, which defaults to submit, not button, and that can be unexpected.

What is the new behavior?

Templates explicitly specify button type attributes as button.

Other information

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 75fcac6c41d285f255cdb0f4cd29c4c8040e479d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ryansolid commented 1 month ago

Thanks

hamirmahal commented 1 month ago

You're welcome.