solidjs / solid-start

SolidStart, the Solid app framework
https://start.solidjs.com
MIT License
4.93k stars 371 forks source link

feat: log errors in production #1519

Closed katywings closed 1 month ago

katywings commented 1 month ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

The production builds swallow runtime errors, making it extremely hard to debug production specific bugs.

What is the new behavior?

Errors that are catched by the ErrorBoundary are logged in the console.

Other information

One problem with this is, that people likely wanna use a different logger than console.error - depending on their infrastructure. Ideally we should have some way to globally configure the logger for internal systems such as the ErrorBoundary 🤔. That would also help to make the logger deploy-platform agnostic.

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 73a2635a57ffcd65afab635949d9a029f29e5007

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------- | ----- | | @solidjs/start | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR