Closed Brendonovich closed 2 weeks ago
Latest commit: 8deefdfe779da09649511fd177cfc907bd1677a9
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The types for
config.vite.server
currently allow all of Vite'sserver
options, many of which are irrelevant since Vinxi overrides or disables them. This can lead to confusion (#1435) around where to configure things like dev server host and port.What is the new behavior?
I've changes the type of
config.vite.server
to omit some entries that don't do anything in Solid Start (and Vinxi for that matter):middlewareMode
: Hardcoded totrue
by Vinxi. This stops Vite from spawning HTTP servers, making all the below options unnecessary:port
: Should be provided with--port
orPORT
strictPort
host
: Should be provided with--host
orHOST
open
: No HTTP servers = no Vite URLs to open in browserOther information
The
VinxiViteServerOptions
should probably be upstreamed to Vinxi so that the list of omitted properties can be more accurate.