solidjs / solid-start

SolidStart, the Solid app framework
https://start.solidjs.com
MIT License
4.93k stars 371 forks source link

Omit some keys from Vite server config #1534

Closed Brendonovich closed 2 weeks ago

Brendonovich commented 2 weeks ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

The types for config.vite.server currently allow all of Vite's server options, many of which are irrelevant since Vinxi overrides or disables them. This can lead to confusion (#1435) around where to configure things like dev server host and port.

What is the new behavior?

I've changes the type of config.vite.server to omit some entries that don't do anything in Solid Start (and Vinxi for that matter):

Other information

The VinxiViteServerOptions should probably be upstreamed to Vinxi so that the list of omitted properties can be more accurate.

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: 8deefdfe779da09649511fd177cfc907bd1677a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------- | ----- | | @solidjs/start | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR