solidjs / solid-start

SolidStart, the Solid app framework
https://start.solidjs.com
MIT License
5.07k stars 377 forks source link

ci: have one source of truth for docs check #1542

Closed hamirmahal closed 3 months ago

hamirmahal commented 3 months ago

fixes #1541.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

.github/workflows/doc-checks.yml and .github/workflows/deploy-docs.yml can get out of sync.

What is the new behavior?

There's just 1 workflow file that we use for both checking, and deploying, docs.

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: 58a70f12832f619ab5cb0129fb160836ebb63c53

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ryansolid commented 3 months ago

Thanks

hamirmahal commented 3 months ago

You're welcome.