Open jtag05 opened 5 days ago
I think this is kinda expected that islands doesn't work as expected anymore since its experimental
I understand that it is experimental and essentially in a preview mode. I was just logging the bug so it's a known issue. And if we could resolve it, all the better.
So the client config having an impact is a bit of a red herring. If we add start.experimental.islands ? serverComponents.server() : null
to the server-fns
plugins it resolves the issue without re-enabling the client side routing. I'll keep poking to make sure that all of the code in that function is required or if we could strip it down for the server functions in particular.
Duplicates
Latest version
Current behavior π―
Triggering a server action from a production build when
experimental.islands
are enabled throws a 500 errorCannot find module
for the referenced chunk.Expected behavior π€
Server actions should behave as they do in development as well as a production build with islands disabled.
Steps to reproduce πΉ
minimum repro repository
Steps:
pnpm build
pnpm start
Trigger Action
buttonContext π¦
I tried debugging this locally and the issue seems related to these lines in the vinxi config. Removing the both conditionals for the islands feature re-adds the server functions, but re-adds the client side routing, obviously. Having either of the two conditionals results in the server actions chunk not being generated.
https://github.com/solidjs/solid-start/blob/main/packages/start/config/index.js#L154-L159 https://github.com/solidjs/solid-start/blob/main/packages/start/config/index.js#L192-L196
I will continue to poke around and see if I can solve this but I am not deeply familiar with vinxi or vite apart from a surface level understanding. I do find it odd that the client config is dictating if server actions are being generated though :thinking:
Your environment π