solidjs / solid-start

SolidStart, the Solid app framework
https://start.solidjs.com
MIT License
4.93k stars 371 forks source link

Add `serverComponents.server()` to server-fns plugins when `experimental.islands` is enabled. #1560

Closed jtag05 closed 3 days ago

jtag05 commented 3 days ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Outlined in 1559 TL;DR production builds are not adding server action chunks when experimental.islands are enabled

What is the new behavior?

Chunks are generated as expected

Other information

changeset-bot[bot] commented 3 days ago

⚠️ No Changeset found

Latest commit: f340d48ee703e0cbb6f3e413679a3f6259d867b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

[Click here if you're a maintainer who wants to add a changeset to this PR](https://github.com/jtag05/solid-start/new/issue-1559?filename=.changeset/plenty-chicken-thank.md&value=---%0A%22%40solidjs%2Fstart%22%3A%20patch%0A---%0A%0AAdd%20%60serverComponents.server()%60%20to%20server-fns%20plugins%20when%20%60experimental.islands%60%20is%20enabled.%0A)

jtag05 commented 3 days ago

I'm happy to add tests as soon as I can find where they are for the config file. I felt it was best to open this and start the discussion.

ryansolid commented 3 days ago

Yeah its ok. This was an oversight in a sense. Like I'm not sure this will work perfectly but lets unblock and see what's broken.