solidjs / solid-start

SolidStart, the Solid app framework
https://start.solidjs.com
MIT License
4.94k stars 371 forks source link

feat: automatic theme switching for Tailwind #1564

Closed hamirmahal closed 4 days ago

hamirmahal commented 5 days ago

closes #1563.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

If the system theme changes to night mode, a newly created Solid app would stay in day mode.

What is the new behavior?

A newly created Solid app will switch themes when the system theme changes.

changeset-bot[bot] commented 5 days ago

⚠️ No Changeset found

Latest commit: 9e975b32ae23888445fa888c036ecb7c0b4525f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

hamirmahal commented 5 days ago

With this change

Screencast from 06-27-2024 04:27:01 PM.webm

ryansolid commented 4 days ago

I'm not too worried about the CSS in the examples compared to the functionality of the javascript. Thanks for the PR.

hamirmahal commented 4 days ago

You're welcome!