search

solidjs / solid-start

SolidStart, the Solid app framework
https://start.solidjs.com
MIT License
4.94k stars 371 forks source link

[Bug?]: `compressPublicAssets` nitro config does not work #1569

Open huseeiin opened 2 days ago

huseeiin commented 2 days ago

Duplicates

Latest version

Current behavior 😯

when i enabled brotli it errors [5:22:22 PM] ERROR Cannot find module "/home/hussein/Desktop/solid-project/.output/server/index.mjs" from "/home/hussein/Desktop/solid-project/node_modules/vinxi/bin/cli.mjs"

Expected behavior 🤔

No response

Steps to reproduce 🕹

Steps:

1. 2. 3. 4.

Context 🔦

No response

Your environment 🌎

No response

mdynnl commented 16 hours ago

did you forget to include steps? anyway, can't seem to reproduce this.

  1. both brotli and gzip are enabled by default and working.
  2. compressPublicAssets: false disables both.
  3. compressPublicAssets: { gzip: false, brotli: false } disables each respectively.

tested with solid-start/basic template

├── @solidjs/meta@0.29.4
├── @solidjs/router@0.13.6
├── @solidjs/start@1.0.2
├── solid-js@1.8.18
└── vinxi@0.3.12
huseeiin commented 3 hours ago

did you forget to include steps? anyway, can't seem to reproduce this.

1. both `brotli` and `gzip` are enabled by default and working.

2. `compressPublicAssets: false` disables both.

3. `compressPublicAssets: { gzip: false, brotli: false }` disables each respectively.

tested with solid-start/basic template

├── @solidjs/meta@0.29.4
├── @solidjs/router@0.13.6
├── @solidjs/start@1.0.2
├── solid-js@1.8.18
└── vinxi@0.3.12

with the basic example i'm only seeing gzip in the network tab image