search

solidjs / solid-start

SolidStart, the Solid app framework
https://start.solidjs.com
MIT License
5.19k stars 375 forks source link

initial render of a Route with text only is not properly removed when navigating away. #776

Closed LiQuidProQuo closed 10 months ago

LiQuidProQuo commented 1 year ago

when the initial render of the route is a text node only navigation to a different route, will not remove the node.

https://stackblitz.com/edit/github-htdqaw image

/ -> /about -> /

image

expectations

  1. navigation should be consistent for when the initial route render from ssr is a text only result keep in mind that if we refresh the /about page, and force initial render on that route then navigation is correct and there is not left overs of nodes when toggling routes.
LiQuidProQuo commented 1 year ago

This issue is not exclusive to text only routes, but also for the case that the route returns a fragment, with top level text nodes

<>
I am top level node
<div>no problem here</div>
again problem I am at top level
</>

it is possible that solid can't properly or easily track text nodes in a top level of the fragment in the current implementation.

and this is not a top priority, but it will be nice to properly communicate to the users why things are not working as expected.

lxsmnsyc commented 1 year ago

iirc this is an issue with text nodes + fragments, there's a similar issue in the SolidJS repo.

ryansolid commented 10 months ago

In setting up for SolidStarts next Beta Phase built on Nitro and Vinxi we are closing all PRs/Issues that will not be merged due to the system changing. If you feel your issue was closed by mistake. Feel free to re-open it after updating/testing against 0.4.x release. Thank you for your patience.

See https://github.com/solidjs/solid-start/pull/1139 for more details.