search

solidjs / solid-styled-components

A 1kb Styled Components library for Solid
MIT License
280 stars 26 forks source link

Fix of hydration and update of goober version #30

Closed SogoCZE closed 2 years ago

SogoCZE commented 2 years ago

Hello,

I've fix hydration of styled components and also update solid and goober version to newest in package.json. I also update the package version.

ryansolid commented 2 years ago

Hmm this actually broke my example: https://codesandbox.io/s/solid-styled-components-yv2t1?file=/index.js. Looking into it now.

ryansolid commented 2 years ago

I know what it is.. we lost reactivity. I will fix it up.

ryansolid commented 2 years ago

FIxed 0.28.3

SogoCZE commented 2 years ago

FIxed 0.28.3

Thanks! It was because I used spread operator instead of mergeProps and also i didn't make proper getter for children, I see. Noted. I am still pretty new to the Solid magic :).