solidjs / solid-styled-components

A 1kb Styled Components library for Solid
MIT License
280 stars 26 forks source link

Fixing Nits #31

Closed jvanderen1 closed 1 year ago

jvanderen1 commented 2 years ago

As I was exploring #29, I came across some minor stuff that I figured would be good to add to the codebase:

I am definitely open to feedback / suggestions.

jvanderen1 commented 2 years ago

The diffing on src/index.js got affected by prettier it seems. If this is an eye-sore, I can remove the prettier changes from this file 👍🏻 .

jvanderen1 commented 2 years ago

@ryansolid Is there anyone you'd recommend to review this?

ryansolid commented 2 years ago

Hmm.. because of all the changes the diff on index.js is basically useless. It might be better without prettier, so I can make sense of it.

jvanderen1 commented 2 years ago

@ryansolid Yeah, I agree. I will remove the prettier change in index.js.

Maybe in a different PR, we could introduce linting/prettier rules to run on every commit. This can be achieved with something like husky + lint-staged.

jvanderen1 commented 2 years ago

@ryansolid I pushed out index.js without prettier changes. Lmk if there's anything else 👍🏻 .