dispose is not a function error in test

solidjs / solid-testing-library

Simple and complete Solid testing utilities that encourage good testing practices.

MIT License

201 stars 19 forks source link

dispose is not a function error in test #49

Closed sysmat closed 10 months ago

sysmat commented 11 months ago

node ver: 18.19.0

dep

"@solidjs/testing-library": "^0.8.4",
"@testing-library/user-event": "^14.5.1",
"@vitest/coverage-v8": "^0.34.6",
"typescript": "^5.3.2",
"vite": "^5.0.4",
"vite-plugin-solid": "2.7.2",
"vitest": "^0.34.6",
"solid-js": "^1.8.7",

Omikorin commented 11 months ago

@sysmat this issue is correlated to #48

The only fix for you now is to rollback vitest to 0.34.2 or use Node 18.18.2. In Node 18.19.0 they backported a breaking change in module resolution.

joeatwawa commented 10 months ago

Note that this seems to be resolved when using the latest version of vitest (which is 1.2.0 at the time of this writing).

atk commented 10 months ago

I moved from throwing an error to issuing a warning. I also updated vite-plugin-solid so it should do most of the required testing config for you (except for globals, coverage, watch, etc.).