Open timbasel opened 2 months ago
Latest commit: ef64150bf90de6eed25aac5fa7ae537ba073433b
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Directionally I'm not opposed. I've considered adding symbol or having helpers to do the wrapping. Technically you can add the PROXY symbol to your class and define your own wrapper today.
My thinking though is like MobX there is perhaps more involved than just auto wrapping every property. I think we should consider something like MobX makeObservable
if we go this way. And I think that requires a bit more thought than just enabling it.
Summary
This PR allows classes to be wrapped inside a store. It implements the very small change outlined by @Reinhard2019 in the Issue #1661.
Even if the issue was closed as
wontfix
I do believe that the functionality is tremendously useful. It has no effects on existing code because it is an opt in on a class by class bases.To make a class wrappable you just define the
$WRAP
property (I've added a minimal helper function to do this) in the constructor of the class.You can even make just individual instances wrap, by calling
makeWrappable
just on the created instance.