solidjs / solid

A declarative, efficient, and flexible JavaScript library for building user interfaces.
https://solidjs.com
MIT License
32.17k stars 918 forks source link

forward all args from `lazy` wrapper to component #2167

Closed MrFoxPro closed 4 months ago

MrFoxPro commented 4 months ago

Summary

Since component is a simple functions and can be called outside of JSX, it can accept multiple arguments. I'm using this to pass some metadata to pages in my custom router.

How did you test this change?

I didn't

changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: 455499c2c7cbee20441f11c97ab9fcf11b7920f7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9205120509

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/solid/src/render/component.ts 3 5 60.0%
<!-- Total: 3 5 60.0% -->
Totals Coverage Status
Change from base Build 8821517881: -0.02%
Covered Lines: 4187
Relevant Lines: 4410

💛 - Coveralls