Universal Renderer's cleanup method doesn't remove existing node

[nyanrus]

Describe the bug

Universal Renderer's cleanup method (the return value of render function) doesn't remove the existing node, which is inconvenient for using HMR.

Your Example Website or App

https://stackblitz.com/edit/solidjs-templates-ycgqgq?file=src%2Findex.tsx

Steps to Reproduce the Bug or Issue

1. See the rendered result.

Expected behavior

I ran the cleanup method and I expected the node to be removed.

Screenshots or Videos

Platform

• OS: Windows 11
• Browser: Firefox
• Version: 115

Additional context

I am using solid-js for Firefox XUL, non-standard HTML, for developing a custom browser. While I making HMR using Vite, I encountered the problem. Thank you for the good project!

[this-spring]

Universal render method is different client render method.

client render method will clean nodeselement.textContent = "";

I am not sure whether universal render need add this logic.

[nyanrus]

Thank you for the reply. I'll implement with overriding the render method. Thanks! By the way, I think it will be good if there are some docs or codes that guides/allows to implement custom cleanup method.

[this-spring]

emmm, I think cleanup is inner logic. It should not implement custom by users. Override render method is good way.