search

solidjs / templates

Vite + solid templates
440 stars 119 forks source link

typecheck command for typescript templates #70

Open carcinocron opened 1 year ago

carcinocron commented 1 year ago

Vue 3 has in it's default package.json:

{
  "scripts": {
    "typecheck": "vue-tsc --noEmit -p tsconfig.vitest.json --composite false"
  }
}

I noticed that this command seems to work for the current solidjs typescript templates:

tsc -p ./tsconfig.json

is that the optimal command for typechecking a solidjs app? We should add it for all typescript templates.

In Vue 3, yarn run dev also outputs typechecking information, is it possible to add that to the solidjs typescript templates?

amoutonbrady commented 1 year ago

Hey, thanks for filling out an issue 🙏🏻

I'm not entirely sure if this is the best way to typecheck a Solid project. For the record I've written a project with more than 12k lines of Solid and almost never had the need to it (although it probably bit me once or twice in CI).

I'm not against adding an extra typecheck script if that can help some people get things running but I won't have the time to see how and if we should try to parallelize type checking in dev.

Would you be open for a PR ? :)