search

solidjs / vite-plugin-solid

A simple integration to run solid-js with vite
440 stars 51 forks source link

Should omitNestedClosingTags be actually required? #149

Closed deluksic closed 8 months ago

deluksic commented 8 months ago

https://github.com/solidjs/vite-plugin-solid/blob/dfdd6d2f6cbd0de2e7f69872275eae5c3a8b9066/src/index.ts#L87

Should it actually be required, or is this an accidental omission? (missing ?)

It does have a default of false, so my assumption is that users should be able to modify other flags without mentioning this one.

ryansolid commented 8 months ago

Yeah this is odd. I've changed it. WIll be fixed in the next release.