search

solidstate-network / solidstate-solidity

💠 Upgradeable-first Solidity smart contract development library 💠
https://discord.gg/BnvwfM6bRe
MIT License
437 stars 89 forks source link

resolve TODO in DiamondFallback.sol #213

Closed vsmelov closed 1 year ago

vsmelov commented 1 year ago

it's not clear why TODO is placed there https://github.com/solidstate-network/solidstate-solidity/blob/master/contracts/proxy/diamond/fallback/DiamondFallback.sol#L10 there is an import of IDiamondFallback, isn't it enough?

maybe just remove the line, it's confusing, it looks like the contract is not coomplete

ItsNickBarry commented 1 year ago

Fixed in 7be27707a219634aeb07aafeac9f85e301138e53.