WIP Add complete unit tests to the weight_limit spec

solidusio-contrib / solidus_active_shipping

:package: Solidus integration for Shopify's active_shipping gem.

8 stars 22 forks source link

WIP Add complete unit tests to the weight_limit spec #10

Closed fredericboivin closed 8 years ago

fredericboivin commented 8 years ago

The weight limit spec and the associated methods contains a lot of code who looks unreachable or that we're not sure why or how it works (or even if we need it)

The plan would be to remove, refactor or extract some of those parts but they are virtually untested so I've begun adding unit tests for each individual methods.

This is a work in progress, comments and suggestions are very welcome.

I also used transpec to update the syntax.

forkata commented 8 years ago

@dangerdogz If you want, pull the first commit in a separate PR and we can run transpec on all the specs and merge that separately while you are working on the weight refactor/specs.

fredericboivin commented 8 years ago

Won't be used since we went another way but I documented some bugs in there so leaving it around until I can fix them for sure (related to issue #28 )