search

solidusio-contrib / solidus_active_shipping

:package: Solidus integration for Shopify's active_shipping gem.
8 stars 22 forks source link

Add integration test for UPS calculators #11

Closed forkata closed 8 years ago

forkata commented 8 years ago

This change builds on Kevin's work for adding integration tests for the UPS shipping calculators and extracts the setup needed into shared contexts. The idea is to provide a framework we can use for integration tests for all the provides we have calculators for.

This change relies on the :order_with_line_items factory having a transient attribute for stock_location, which was added in v1.2, so it adds a commit that brings that into the extension to make tests pass in Spree 1.0 and 1.1.

fredericboivin commented 8 years ago

:+1:

This is nice and concise

Senjai commented 8 years ago

:+1: This is awesome

forkata commented 8 years ago

Added one more change to ensure that we run in test mode, this only needs to be set once per test run, but for now I think it's okay that it lives in each carrier test setup since that's the only place we allow net connections from.