Remove address from shipment in order_factory override

solidusio-contrib / solidus_active_shipping

:package: Solidus integration for Shopify's active_shipping gem.

8 stars 22 forks source link

Closed fredericboivin closed 8 years ago

fredericboivin commented 8 years ago

Solidus PR#1138 deprecated the address field in the shipment model, the edited factory was still using this field, causing test failures everywhere.

fredericboivin commented 8 years ago

For versions before master, the field is still there (but it's not used so no harm in removing it)

What do you think Chris?

forkata commented 8 years ago

@dangerdogz This looks good to me, we shouldn't be assigning address on shipment anyways so this is a good change. :+1: